Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global config issue in 7.0.0 #223

Closed
EPK-nl opened this issue Jun 13, 2023 · 2 comments · Fixed by #226
Closed

Global config issue in 7.0.0 #223

EPK-nl opened this issue Jun 13, 2023 · 2 comments · Fixed by #226

Comments

@EPK-nl
Copy link

EPK-nl commented Jun 13, 2023

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 7.23.0
  • Ruby: 2.5.9p229
  • Distribution: RHEL 8.7
  • Module version: 7.0.0

How to reproduce (e.g Puppet code you use)

Hiera:

rsyslog::config::global_config:
  workDirectory:
      value: '/var/lib/rsyslog'

But also rsyslog::config::modules, rsyslog::config::actions and rsyslog::config::legacy_config

What are you seeing

In version 6.0.0 this resulted in a part in de rsyslog.d/50_rsyslog.conf file containing a global workDirectory setting.
In version 7.0.0 with exactly the same hiera data, only that global part is removed.

What behaviour did you expect instead

No change between version 6 and 7 of this module while parsing these parameters.

Output log

Lines with the global config setting are removed.

Any additional information you'd like to impart

Result in our case is a disfunctional rsyslog, with SELinux reporting a lot of issues for rsyslog for not being able to open imjournal.

@emperortomato
Copy link

I'm seeing the same thing; the only way to get it to install the global config values in 7.0.0 seems to be setting type: 'legacy'

@kenyon
Copy link
Member

kenyon commented Jun 18, 2023

This is due to 58cb84e (#216) somehow...

@kenyon kenyon added the bug Something isn't working label Jun 18, 2023
kenyon added a commit that referenced this issue Jun 18, 2023
The ! has higher precedence than the `in` operator.

Fixes #223.
@smortex smortex removed the bug Something isn't working label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants