Add Job management #530
Merged
Add Job management #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add param to notify connection check when rundeck::service is changed
bastelfreak
reviewed
Feb 26, 2024
Joris29
force-pushed
the
job_management
branch
4 times, most recently
from
1be6e72
to
efae965
Compare
|
@bastelfreak tests failing due to: read timeout reached |
smortex
reviewed
Feb 27, 2024
files/rd_job_diff.sh
Outdated
Comment on lines
12
to
13
| diff "$path" "$temp_file" &> /dev/null | ||
| DIFF_STATUS=$? |
There was a problem hiding this comment.
We can rely on cmp(1) to silently compare files instead of generating a diff only to discard it.
Suggested change
| diff "$path" "$temp_file" &> /dev/null | |
| DIFF_STATUS=$? | |
| cmp -s "$path" "$temp_file" |
There was a problem hiding this comment.
Updated the script do you like this approach better?
Joris29
force-pushed
the
job_management
branch
from
efae965
to
d19c8bc
Compare
bastelfreak
reviewed
Feb 29, 2024
bastelfreak
reviewed
Feb 29, 2024
bastelfreak
reviewed
Feb 29, 2024
Joris29
force-pushed
the
job_management
branch
from
d19c8bc
to
b72ed4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds a way to manage jobs through cli and adds a parameter to notify cli connection check
This Pull Request (PR) fixes the following issues
Fixes #33
Fixes #458