Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.0.0 #87

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Release 6.0.0 #87

merged 1 commit into from
Jul 30, 2023

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not used to having issues in PR. Here this seems even more annoying than when we have both the issue and the fix/enhancement which duplicate the information because we "advertise" a feature which was not implemented.

CHANGELOG.md Outdated

**Closed issues:**

- Allow for overwriting of the SSH keys [\#82](https://github.com/voxpupuli/puppet-ssh_keygen/issues/82)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was closed but not done so I think this should not be part of the ChangeLog and that we should label the issue skip-changelog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah indeed, I reopened the isue because it's not fixed yet

@bastelfreak bastelfreak merged commit 003f663 into voxpupuli:master Jul 30, 2023
4 checks passed
@bastelfreak bastelfreak deleted the rel600 branch July 30, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants