add local_zone and domain_insecure parameters #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add type and spec update update - - - update -
zachfi
reviewed
Jan 27, 2018
| @@ -6,6 +6,8 @@ | |||
| Hash $forward, | |||
| Hash $stub, | |||
| Hash $record, | |||
| Optional[Unbound::Local_zone] $local_zone, | |||
There was a problem hiding this comment.
Just looking over the man page, looks like multiple local-zone definitions are allowed. This should probably be Optional[Array[Unbound::LocalZone]] to allow multiple local zones. The template will also need adjusting.
There was a problem hiding this comment.
type Unbound::Local_zone = Hash[String, Unbound::Local_zone_type] so you can pass multiple zones here, template already accounts for this
|
This looks good. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of #151 and #152