Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular expression in fact unbound_version. #168

Closed
wants to merge 1 commit into from

Conversation

sst-yde
Copy link
Contributor

@sst-yde sst-yde commented May 9, 2018

\d matches a single digit, so a version like 1.4.20 will result in the fact unbound_version containing 1.4.2 instead of 1.4.20. The new expression will match a number (one or more digits), followed by any number of dots which are immediately followed by a number. This way we're able to match 1, 1.2, 1.2.3, 1.2.3.4 etc.

@zachfi
Copy link
Contributor

zachfi commented May 10, 2018

Thanks for the PR. Would you be able to add a test for this change? The regex looks good, but a test would make sure this supports the rest of the version strings you've mentioned above.

@zachfi
Copy link
Contributor

zachfi commented May 21, 2018

I've tried to add a test in #173 but it didn't work at first pass. I can come back to look closer later.

@zachfi
Copy link
Contributor

zachfi commented Sep 30, 2019

#207

@zachfi
Copy link
Contributor

zachfi commented Oct 4, 2019

Thank you for the PR here. Sorry for such a slow response. I've tried three times now at different time s to get a test that works for this and have failed every time. I've tested this manually and all looks good to me. I'll merge #211 to remove the newline.

@zachfi zachfi closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants