Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo is always added #148

Closed
throwaway99 opened this issue Jan 21, 2016 · 4 comments
Closed

Repo is always added #148

throwaway99 opened this issue Jan 21, 2016 · 4 comments
Labels
bug Something isn't working

Comments

@throwaway99
Copy link

In zabbix::repo the if ($manage_repo) { does not seem to do anything. If you define zabbix::repo as false the repo is still added.

This is applying the class zabbix. If you only apply zabbix::agent the repo is not added.

@dj-wasabi dj-wasabi added the bug Something isn't working label Jan 28, 2016
@dj-wasabi dj-wasabi added this to the 2.0.0 milestone Jan 28, 2016
@dj-wasabi
Copy link
Contributor

Hi @throwaway99

Could you please show me your site manifest?

When I have this:

class { 'zabbix::agent':
  server      => 'zabbix.example.com',
  manage_repo => false,
}

it works like it should. No yum repository file is created.

@dj-wasabi dj-wasabi removed this from the 2.0.0 milestone Feb 1, 2016
@throwaway99
Copy link
Author

Hi,

It's a Zabbix server and it's defined in Hiera as:-

classes:

  • 'zabbix'

Zabbix configuration

zabbix::database_type: 'mysql'
zabbix::manage_firewall: false
zabbix::manage_repo: false
zabbix::manage_vhost: false

The example you give works fine as servers with

classes:

  • 'zabbix::agent'

do not have the repository applied but where I apply

classes:

  • 'zabbix'

it does create the repository. Hope this helps.

dj-wasabi added a commit that referenced this issue Feb 9, 2016
@dj-wasabi
Copy link
Contributor

I pushed an fix to the repo and created an release 2.1.1. Can you verify that it works as expected?

@throwaway99
Copy link
Author

Hi. Yes works as expected. Thanks for this and the module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants