Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix.conf.php.erb wrong zbx name #9

Closed
Nekroze opened this issue Oct 16, 2014 · 4 comments
Closed

zabbix.conf.php.erb wrong zbx name #9

Nekroze opened this issue Oct 16, 2014 · 4 comments

Comments

@Nekroze
Copy link

Nekroze commented Oct 16, 2014

This template contains the following line:

$ZBX_SERVER = '<%= @dbhost %>';

This causes the web interface to look to the database server for the zabbix-server which is not always the case.

This can be fixed by changing the line to:

$ZBX_SERVER = '<%= @fqdn %>';

Sorry i cannot make a pull request for this one.

Love the module, keep up the good work mate.

@dj-wasabi
Copy link
Contributor

Hi Nekroze,

You are right. But if I want to do it right, I should create an seperate class for the web interface. With the current setup, I assume everything is installed on 1 server. This will work for most people, but when you seperate it on different servers this module won't work correctly.

I can for now update the file like you mentioned, but I'll do this the correct way like mentioned above with the 1.0.0 release.

Is that okay?

Kind regards,
Werner

@Nekroze
Copy link
Author

Nekroze commented Oct 16, 2014

@dj-wasabi Hi, You are correct the web application could be split from the zabbix server however currently it is not so in order to maintain the flexibility of the current zabbix server model in your module this fix would be required. As such i completely endorse putting this fix in for now and later splitting off the web interface to a separate class.

Thanks a heap for the swift response.

dj-wasabi pushed a commit that referenced this issue Oct 17, 2014
@dj-wasabi
Copy link
Contributor

Hi Nekroze,

I just pushed the updated file to github.
Probably with a week I'll create new version and put it into the forge.

Kind regards,
Werner

@Nekroze
Copy link
Author

Nekroze commented Oct 19, 2014

Cheers Werner,

Thanks for the assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants