Puppetgem #158
Merged
Puppetgem #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t allow overriding of the value.
|
Fixes #158 |
|
@dj-wasabi I'm working on the Travis CI setup, but it's going to take a while because $rubocop. Can you enable it on the repo? I know it kinda muddies the water to have two changes in one PR but it's the best way I know to make sure this described changed is made effectively :) |
|
Thanks! Think I should create a new version with this PR. |
|
@dj-wasabi I'm still working out the rspec issues, I'll open a new PR for that. They should probably be resolved before the new version release, though. |
|
Ok, thank you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.