New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppetgem #158

Merged
merged 5 commits into from Feb 1, 2016

Conversation

Projects
None yet
2 participants
@rnelson0
Copy link
Member

rnelson0 commented Feb 1, 2016

No description provided.

@rnelson0

This comment has been minimized.

Copy link
Member

rnelson0 commented Feb 1, 2016

Fixes #158

@rnelson0

This comment has been minimized.

Copy link
Member

rnelson0 commented Feb 1, 2016

@dj-wasabi I'm working on the Travis CI setup, but it's going to take a while because $rubocop. Can you enable it on the repo? I know it kinda muddies the water to have two changes in one PR but it's the best way I know to make sure this described changed is made effectively :)

dj-wasabi added a commit that referenced this pull request Feb 1, 2016

@dj-wasabi dj-wasabi merged commit 379e795 into voxpupuli:master Feb 1, 2016

@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

dj-wasabi commented Feb 1, 2016

Thanks! Think I should create a new version with this PR.

@rnelson0

This comment has been minimized.

Copy link
Member

rnelson0 commented Feb 1, 2016

@dj-wasabi I'm still working out the rspec issues, I'll open a new PR for that. They should probably be resolved before the new version release, though.

@dj-wasabi

This comment has been minimized.

Copy link
Collaborator

dj-wasabi commented Feb 1, 2016

Ok, thank you. 👍
I'll wait with the next release until a new PR is created.

@rnelson0 rnelson0 deleted the rnelson0:puppetgem branch Feb 1, 2016

@dj-wasabi dj-wasabi added this to the 2.1.0 milestone Feb 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment