Fix for php db package name on Ubuntu 16.04 #284
Conversation
|
It looks like the |
|
Hi @frozenfoxx, thanks for the PR! I guess you have to do something disgusting like I did here: |
frozenfoxx
force-pushed
the
xenialdbpackagename
branch
from
fca9e77
to
c9bbe8b
Compare
| @@ -56,7 +56,20 @@ def package_provider_for_gems | |||
| let :params do | |||
| super().merge(database_type: 'postgresql') | |||
| end | |||
| packages = facts[:osfamily] == 'RedHat' ? ['zabbix-web-pgsql', 'zabbix-web'] : ['zabbix-frontend-php', 'php5-pgsql'] | |||
|
|
|||
| pgsqlpackage = "" | |||
| @@ -67,7 +80,20 @@ def package_provider_for_gems | |||
| let :params do | |||
| super().merge(database_type: 'mysql') | |||
| end | |||
| packages = facts[:osfamily] == 'RedHat' ? ['zabbix-web-mysql', 'zabbix-web'] : ['zabbix-frontend-php', 'php5-mysql'] | |||
|
|
|||
| mysqlpackage = "" | |||
| case facts[:osfamily] | ||
| when 'Debian' | ||
| if facts[:operatingsystemmajrelease] >= '16.04' | ||
| pgsqlpackage = "php-pgsql" |
There was a problem hiding this comment.
migrate all of the double quotes to single quotes unless they contain a variable
|
|
||
| pgsqlpackage = "" | ||
| case facts[:osfamily] | ||
| when 'Debian' |
There was a problem hiding this comment.
please migrate to ConditionalAssignment
| mysqlpackage = "" | ||
| case facts[:osfamily] | ||
| when 'Debian' | ||
| if facts[:operatingsystemmajrelease] >= '16.04' |
There was a problem hiding this comment.
same here, please migrate to ConditionalAssignment
| @@ -56,7 +56,25 @@ def package_provider_for_gems | |||
| let :params do | |||
| super().merge(database_type: 'postgresql') | |||
| end | |||
| packages = facts[:osfamily] == 'RedHat' ? ['zabbix-web-pgsql', 'zabbix-web'] : ['zabbix-frontend-php', 'php5-pgsql'] | |||
|
|
|||
| pgsqlpackage = case facts[:operatingsystem] | |||
There was a problem hiding this comment.
almost feels like package maintainer hate us
As explained in #282 the code for installing the php5 database package does not currently work on Ubuntu 16.04. This is because the name has changed from "php5-${db}" to "php-${db}" in the official repos. This pull will update it only in those instances and still use the legacy facts for determining version for backward compatibility.