Adapt to zabbix-3.2 and higher. #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @yevtushenko , thanks for the PR. Can you please take a look at the failed spec tests and also add a few new ones that test several zabbix versions? |
|
@bastelfreak I'll do it soon. |
yevtushenko
force-pushed
the
adapt_to_3.2
branch
6 times, most recently
from
919ab1e
to
6331009
Compare
yevtushenko
force-pushed
the
adapt_to_3.2
branch
from
6331009
to
4dfabda
Compare
|
@bastelfreak It very strange that test fails. I've run test on my machine and it passed successfully. |
yevtushenko
force-pushed
the
adapt_to_3.2
branch
from
b9b83c3
to
e8f8f06
Compare
|
Seems to be fine now, thanks @yevtushenko! |
|
@bastelfreak I've removed the mysql tests for zabbix-3.2 which I added before because it fails on these new tests. I think these tests should be there, so I can try to create separate PR for them. |
|
Yes, please create a seperate PR. |
|
@bastelfreak Also current PR covers #286 and #287 (including tests you requested). |
This was referenced Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to adapt module to zabbix-3.2 and higher versions.
Some of
3.0strings replaced with regular expressions, some@zabbix_version == '3.0'replaced with@zabbix_version >= '3.0'.