Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual bridge (virbr) to the list of network interfaces that are checked when setting listenip #324

Merged
merged 1 commit into from
Dec 7, 2016

Conversation

markfaine
Copy link
Contributor

See Issue #323 (Feature Request)

Added virbr interface to list of matched interfaces. This change allows the IP address to be set from the IP address assigned to a virtual bridge network interface.

I did not add enp.* since that would require a more substantial modification of the code in order to do correctly since the current matching only matches at the end while predictable network interface names such as enp.* actually match in two locations: enp[0-9]+s[0-9]+

@bastelfreak
Copy link
Member

Hi @markfaine, thanks for the PR. Can you please add the used email addr to your profile? github is unable to assign the commit to your account.

@markfaine
Copy link
Contributor Author

@bastelfreak My profile does have an address, though maybe a different address was used for the commit. I've added that address. See if it works now.

@bastelfreak
Copy link
Member

thanks!

@bastelfreak bastelfreak merged commit 4942f77 into voxpupuli:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants