Add manage_init_script parameter #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
force-pushed
the
feature/manage_init_script
branch
from
029ed8d
to
865a508
Compare
|
I'm pretty sure the failing test isn't related to my code change. In fact, i can't even reproduce this on my local machine oO |
alexjfisher
requested changes
Oct 31, 2018
manifests/agent.pp
Outdated
| @@ -177,6 +177,9 @@ | |||
| # [*loadmodule*] | |||
| # Module to load at agent startup. | |||
| # | |||
| # [*manage_init_script*] | |||
There was a problem hiding this comment.
zabbix::startup manages systemd instead of init scripts on some systems, so this parameter name may not be the best choice.
There was a problem hiding this comment.
Would you prefer manage_startup_script? :)
There was a problem hiding this comment.
works for me. @bastelfreak - sound ok?
There was a problem hiding this comment.
sounds good to me. @baurmatt can you update it please?
There was a problem hiding this comment.
Done. Didn't change the branch name though ;)
baurmatt
force-pushed
the
feature/manage_init_script
branch
from
865a508
to
2791a99
Compare
baurmatt
force-pushed
the
feature/manage_init_script
branch
from
2791a99
to
719257e
Compare
bastelfreak
approved these changes
Nov 2, 2018
|
@alexjfisher can you have a look again? |
alexjfisher
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds a parameter
manage_init_scriptwhich makes it possible to disable the Init File management.This Pull Request (PR) fixes the following issues
Fixes #541.