Implement self.prefetch for zabbix_host

[baurmatt]

Pull Request (PR) description

This commits adds the following improvements to zabbix_host:

• Implement self.prefetch (This allows the use of puppet resource zabbix_host as well as purging unmanaged zabbix_host resources)
• Implement proper setters for all properties
• Rename the group parameter to groups to allow multiple groups to
  be specified

This is another change for #570.

This Pull Request (PR) fixes the following issues

[bastelfreak]

Please add a datatype for the new option.

[baurmatt]

Done :)

[bastelfreak]

@baurmatt can you take a look at the rubocop issues and add some tests for it? Thanks for the great work!

[baurmatt]

@bastelfreak Thanks! :) I've fixed the rubocop issues. Will take a look at unit tests for the type/provider.

[baurmatt]

@bastelfreak I've implemented all tests for the custom type. But the provider seems to be out of my league. From my understanding, that would require a complete mock of the Zabbix API.

[bastelfreak]

Thanks for all the work!

[guzmanbraso]

Hey, this commit broke our environments as the parameter group of manifests/resources/agent.pp was not renamed:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: no parameter named 'groups' (file: /etc/puppetlabs/code/environments/x/modules/zabbix/manifests/resources/agent.pp, line: 38) on Zabbix_host[x] (file: /etc/puppetlabs/code/environments/x/modules/zabbix/manifests/resources/agent.pp, line: 38) on node x

[baurmatt]

@guzmanbraso First of all, sorry that it broke your environment! I will look into it and open up a new PR with the fix soon.

[baurmatt]

Hey @guzmanbraso, so I've just tried to understand what the problem could be, but sadly failed. manifests/resources/agent.pp still has the group parameter additionally to the new groups parameter:

puppet-zabbix/manifests/resources/agent.pp

Lines 21 to 22 in 580b484

	$group = undef,
	Array[String[1]] $groups = undef,

Could you please provide more information about what the problem is?

[alexjfisher]

@guzmanbraso Are you running puppet generate types to prevent environment isolation issues?

To me, it looks like your puppetserver doesn't realise the type contains a new groups parameter.

[guzmanbraso]

@baurmatt, no need to be sorry, my message was not a complain, just wanted to share that information wiyh you guys. Because $groups was defined with spec I missed when fast searching for it and took as granted that $group had to be renamed. My bad

@alexjfisher will check that out and get back to you, I did not tested if it was an environment isolation issue, thought it was something more basic but clearly it's not. I'll test that and get back to you.

Thank you everyone for your support!

[alexjfisher]

There were similar errors reported when puppetlabs/apt gained a new parameter in one of its ruby types. See #569 (comment)

[hferrag]

Hey, this commit broke our environments as the parameter group of manifests/resources/agent.pp was not renamed:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: no parameter named 'groups' (file: /etc/puppetlabs/code/environments/x/modules/zabbix/manifests/resources/agent.pp, line: 38) on Zabbix_host[x] (file: /etc/puppetlabs/code/environments/x/modules/zabbix/manifests/resources/agent.pp, line: 38) on node x

I had exactly the same problem as @guzmanbraso

[hferrag]

I had exactly the same problem as @guzmanbraso
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: no parameter named 'groups' (file: /etc/puppetlabs/code/z/modules/zabbix/manifests/resources/agent.pp, line: 39) on Zabbix_host[z] (file: /etc/puppetlabs/code/z/modules/zabbix/manifests/resources/agent.pp, line: 39) on node my-node.local

Fixed after running puppet generate types --environment my_env.

Thanks @baurmatt and @alexjfisher for your support.