Implement self.prefetch for zabbix_hostgroup #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another change for voxpupuli#570.
alexjfisher
reviewed
Feb 22, 2019
| end | ||
| end | ||
| end | ||
|
|
||
| def create | ||
| # Connect to zabbix api | ||
| hgid = zbx.hostgroups.create(name: @resource[:name]) | ||
| hgid |
There was a problem hiding this comment.
Is there any reason for assigning to hgid here? create doesn’t actually need to return anything, does it?
| api_hostgroups.map do |group_name, _id| | ||
| new( | ||
| ensure: :present, | ||
| name: group_name |
There was a problem hiding this comment.
Is provider: :ruby needed here?
Or is that just what I’ve done in the past by blindly following what I read somewhere once?! (Probably http://garylarizza.com/blog/2013/12/15/seriously-what-is-this-provider-doing/)
alexjfisher
approved these changes
Feb 22, 2019
bastelfreak
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
This is another change for #570.