Add support for specifying unsupported repo location. #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Er, zabbix::repo::unsupported_repo_location not path =) |
bastelfreak
reviewed
Jun 8, 2019
bastelfreak
changed the title
bastelfreak
reviewed
Jun 10, 2019
bastelfreak
reviewed
Jun 10, 2019
Switch to using undef instead of ''.
|
@bastelfreak I pushed up an update that includes the fixes you requested. Tests don't pass but they look like they may have been busted for quite some time. Could you please confirm that I didn't cause these? Otherwise, see anything else that needs a tweak? =) Thanks! |
bastelfreak
reviewed
Jun 10, 2019
manifests/repo.pp
Outdated
| String[1] $zabbix_version = $zabbix::params::zabbix_version, | ||
| Boolean $manage_repo = $zabbix::params::manage_repo, | ||
| Boolean $manage_apt = $zabbix::params::manage_apt, | ||
| Stdlib::HTTPUrl $repo_location = $zabbix::params::repo_location, |
There was a problem hiding this comment.
those types need to be optional
Suggested change
| Stdlib::HTTPUrl $repo_location = $zabbix::params::repo_location, | |
| Optional[Stdlib::HTTPUrl] $repo_location = $zabbix::params::repo_location, |
bastelfreak
reviewed
Jun 10, 2019
|
The tests are failing because the new code always requires a value for both variables. They need to be optional (sorry, I missed that during my last review). |
|
oh! my bad just a moment. |
|
I went ahead and make repo_location optional as well since it "really is" . |
|
Much better =) |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This fairly simply PR adds the ability to specify the "unsupported" repo path similar to how you can override the repo_path. (zabbix::repo::unsupported_repo_path is the new setting) I am using this a a temporary measure to get Zabbix running on some RHEL 8 agents before RHEL 8 is even available, but I imagine it could be useful to others who want to mirror the unsupported repo as well. At some level I figured, you can configure one, why not the other. =)
This Pull Request (PR) fixes the following issues
n/a