Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zabbix::proxy idempotency #669

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Fix zabbix::proxy idempotency #669

merged 1 commit into from
Apr 13, 2020

Conversation

alexjfisher
Copy link
Member

Active proxies don't use ipaddress, use_ip or port. Specifically,
the zabbix_proxy provider will return nil for these properties for
active proxies.

@alexjfisher
Fix zabbix::proxy idempotency
3d8dd4b 
Active proxies don't use `ipaddress`, `use_ip` or `port`.  Specifically,
the zabbix_proxy provider will return `nil` for these properties for
active proxies.
@alexjfisher
Copy link
Member Author

This PR hasn't been tested by me. I've created it following an issue reported by @tenajsystems on slack.

@alexjfisher
Copy link
Member Author

From slack...

We have been using this zabbix module: https://forge.puppet.com/puppet/zabbix. Ever since we updated the module from version 6.7.0 to 8.0.0, each time puppet runs on the zabbix server, we get the below corrective changes. I have dug throw everything I can think of but no luck. I think this might be a bug with the module but I could be totally wrong so wanted to share it here just in case someone can point me in the right direction. In the Zabbix GUI ( Administration -> Proxies), there is no field to enter a port for the proxy when the proxy mode is Active. The port field is only available when the proxy mode is Passive so I believe the module is treating everything as Passive when it comes to the GUI. Any suggestions or thoughts on how to stop these corrective changes?
Notice: /Stage[main]/Zabbix::Resources::Web/Zabbix_proxy[zone1-zabbix-proxy]/port: defined 'port' as '10051' (corrective)
Notice: /Stage[main]/Zabbix::Resources::Web/Zabbix_proxy[zone2-zabbix-proxy]/port: defined 'port' as '10051' (corrective)

@tenajsystems
Copy link

@alexjfisher I just tested this pull request and your change worked like a charm! No more corrective changes. Thank you for fixing this bug! When will this be merged and the forge module updated?

@bastelfreak bastelfreak added the bug Something isn't working label Apr 13, 2020
ekohl
ekohl approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is on Ubuntu which also failed in master at the time. Merging.

@ekohl ekohl merged commit dbffa0e into voxpupuli:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexjfisher @tenajsystems @ekohl @bastelfreak