-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Zabbix 5.x #743
Conversation
4540d6f
to
7967056
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I was looking into upgrading to Zabbix 5.0 myself, looked into this PR
But it seems to break on web.pp because of the custom_fragment with all the php_value settings
The var $apache_vhost_custom_fragment is being set, but not used to set the fragment in the vhost if I saw it right. Overall it seems to work just fine if I remove the fragment manually
Thanks! I'll look into it and report back |
Already pushed a PR to your branch with the fix :) |
bed5f23
to
bdb2c26
Compare
6ad137f
to
a54f037
Compare
0b76498
to
d6f3639
Compare
Could we also consider rolling in my branch for adding support for the SAML / SSO settings introduced in 5.x? Doing this will allow #693 to be closed. If it's deemed not appropriate I'll file a seperate PR. |
Not to pile on =) But this setting is pretty important for Zabbix 5: |
PS aside from that I am using @root-expert 's PR fork directly right now for my 5.2 install and it's working great! Mind you I'm not (yet) using the exported resources functionality. |
I think you should open a new request after rebasing with my branch. Also you should write some specs ;)
I believe that PR could be merged if rebased as well. |
d6f3639
to
2436ee6
Compare
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
Signed-off-by: Christos Papageorgiou <root.expert.xda@gmail.com>
2436ee6
to
d8d85ad
Compare
Pull Request (PR) description
Adds support for Zabbix 5.x.
Maybe more tests are needed
Depends on #742
This Pull Request (PR) fixes the following issues
Fixes #731
Closes #737
Closes #736
Closes #721
Closes #715
Closes #694