Respect manage_repo for RedHat family #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root-expert
reviewed
Oct 12, 2021
root-expert
changed the title
|
To be honest that piece of code was probably belonging to If you think you can move it and update the specs please do it, else I'm happy to merge this PR. |
bastelfreak
reviewed
Oct 12, 2021
@root-expert I've moved it to zabbix::repo. The downside of this is that the SCL repo package also gets installed when zabbix::web is not being used. |
root-expert
reviewed
Oct 13, 2021
Co-authored-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
That seems okay for me |
root-expert
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In #736 the CentOS SCL repo was added by installing
centos-release-scl. However, this breaks repository management for folks that have$manage_reposet tofalse.This PR ensure that the SCL repo package is only installed when
$manage_repois set totrue.Another approach would be to move the installation of the
centos-release-sclpackage from zabbix::web to zabbix::repo. Let me know what you think.This Pull Request (PR) fixes the following issues
Having two modules trying to manage the SCL repo leads to all kinds of issues, i.e. duplicate declarations.