Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RedHat 8 support #805

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Conversation

tjikkun
Copy link
Contributor

@tjikkun tjikkun commented Nov 26, 2021

Pull Request (PR) description

This PR adds support for EL-8 hosts. It makes sure php-fpm is used there and adds EL-8 to the tests

This Pull Request (PR) fixes the following issues

Fixes #643
Closes #687

metadata.json Outdated Show resolved Hide resolved
@root-expert root-expert changed the title El8 support Add RedHat 8 support Nov 26, 2021
@root-expert root-expert added the enhancement New feature or request label Nov 26, 2021
Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although we don't acceptance tests due to PID file workaround ☹️

@tjikkun
Copy link
Contributor Author

tjikkun commented Nov 26, 2021

I don't know anything about that pid-file workaround, is that something I can fix? Do you have more info on that subject?

@tjikkun
Copy link
Contributor Author

tjikkun commented Nov 26, 2021

Ah, found it, https://github.com/voxpupuli/puppet_metadata
Unrelated to this PR indeed

@root-expert root-expert merged commit 5c3ed52 into voxpupuli:master Nov 26, 2021
@root-expert
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for CentOS/RHEL 8
3 participants