Drop EoL Ubuntu 16.04 #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Aug 4, 2022
| @@ -151,7 +151,7 @@ | |||
| # zabbix frontend 5.x is not supported, among others, on stretch and xenial. | |||
| # https://www.zabbix.com/documentation/current/manual/installation/frontend/frontend_on_debian | |||
| if $facts['os']['name'] in ['ubuntu', 'debian'] and versioncmp($zabbix_version, '5') >= 0 { | |||
| if versioncmp($facts['os']['release']['major'], '16.04') == 0 or versioncmp($facts['os']['release']['major'], '9') == 0 { | |||
| if versioncmp($facts['os']['release']['major'], '9') == 0 { | |||
There was a problem hiding this comment.
Should it also drop Debian 9, which we also consider unsupported in Vox Pupuli modules.
There was a problem hiding this comment.
I did like to drop it on another PR
Merged
bastelfreak
force-pushed
the
dropubuntu16
branch
from
2bbc207
to
756ff82
Compare
bastelfreak
force-pushed
the
dropubuntu16
branch
from
756ff82
to
64bfcf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Ubuntu 16.04 has been EoL since 30/04/21
This Pull Request (PR) fixes the following issues