Add support for ODBC pollers in Zabbix >= 6.0 #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure does not seem to be related to this PR. |
Please update REFERENCE.md with $ bundle exec rake strings:generate:referenceAdd it to the PR and CI should continue. |
Done. |
|
@fraenki Please consider adding basic tests for the new parameter both for the proxy and the server 😄 |
|
@root-expert Rebased against current master and added basic tests. (Side note: This module runs most tests with zabbix_version=5.0 and zabbix_version=6.0 is not supported for the server class on all operating systems. As a result the tests I've added aren't perfect. But once all tests run with zabbix_version=6.0 everything should be fine.) |
root-expert
reviewed
Oct 18, 2023
root-expert
changed the title
|
@root-expert, all suggested changes applied, thanks. :) |
evgeni
reviewed
Nov 7, 2023
fraenki
force-pushed
the
odbc_pollers
branch
from
01833a5
to
24479d6
Compare
evgeni
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds support for the
StartODBCPollersconfiguration parameter, that was introduced in Zabbix 6.0.This Pull Request (PR) fixes the following issues
This parameter was already discussed in #814 (comment), but a PR was never submitted, AFAICT.