Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CN-29] remove the support of complex64/complex128 #24

Merged

Conversation

vpakhuchyi
Copy link
Owner

@vpakhuchyi vpakhuchyi commented Jan 24, 2024

Pull request

Link to the related ticket

https://censor.atlassian.net/browse/CN-29

Description of changes

Remove the support of complex64/complex128 due to the maintenance issues.
Main reasons:

  • these types can't be represented as a JSON values with no custom implementations
  • it's hard to have the predictable rounding during the formatting (unlike with floats) that damages the consistency of the output

Checklist

Please ensure that your pull request complies with the following requirements:

  • The changes have been tested locally (if applicable).
  • The documentation has been updated (if applicable).

@vpakhuchyi vpakhuchyi self-assigned this Jan 24, 2024
@vpakhuchyi vpakhuchyi merged commit b6327cf into main Jan 24, 2024
3 checks passed
@vpakhuchyi vpakhuchyi deleted the feat/CN-29-remove-complex-64-complex-128-types-support branch January 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant