Support multiple domain names #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriiPyshinskii
approved these changes
Apr 25, 2024
artemirk
reviewed
Apr 25, 2024
| @@ -319,8 +319,8 @@ func (s *Config) validate() error { | |||
| return xerror.EInternalError("ssl.listen_addr is required", nil) | |||
| } | |||
|
|
|||
| if s.Domain == nil || len(s.Domain.Name) == 0 { | |||
| return xerror.EInternalError("SSL server is enabled, but no domain name is set", nil) | |||
| if s.Domain == nil || len(s.Domain.PrimaryName) == 0 { | |||
There was a problem hiding this comment.
better
s.Domain.PrimaryName == ""
artemirk
reviewed
Apr 25, 2024
| // DomainConfig is the YAML version of the `adminAPI.DomainConfig` struct. | ||
| type DomainConfig struct { | ||
| Mode string `yaml:"mode" valid:"required"` | ||
| PrimaryName string `yaml:"name" valid:"dns,required"` |
There was a problem hiding this comment.
Why it's named as PrimaryName Can it be simple Name as yaml defines it's the name
There was a problem hiding this comment.
PrimaryName is better for reading code. "name" in yaml is left for backward compatibility.
artemirk
reviewed
Apr 25, 2024
| } | ||
|
|
||
| if c.Mode == string(adminAPI.DomainConfigModeReverseProxy) { | ||
| if len(c.Schema) == 0 { |
There was a problem hiding this comment.
Worth to have check with c.Schema == "http" || c.Schema == "https" ?
There was a problem hiding this comment.
I didn't change this code, just moved to appropriate place. Let leave as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.