Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual columns #325

Closed
wants to merge 4 commits into from
Closed

Virtual columns #325

wants to merge 4 commits into from

Conversation

vrana
Copy link
Owner

@vrana vrana commented Jan 22, 2019

No description provided.

@vrana
Copy link
Owner Author

vrana commented Jan 22, 2019

Thanks for the extra work. This still has some issues:

  • Extra newline after Auto Increment columns.
  • Not using html_select().
  • Not using lang().
  • Using $jush == 'sql' instead of support().
  • Breaks support for MySQL 4.1 (probably not a big deal but we should strip other MySQL < 5 code elsewhere in a separate commit).
  • Useless GENERATED ALWAYS .
  • Some missing semicolons before ?> (breaks compilation).
  • Always trimming ' from the default value (must be trimmed only since MariaDB 10.2.7).
  • Missing entry in changes.txt.
  • Probably the most important issue is that MariaDB reports the generated columns only since 10.2.5 which removes the virtual value whenever the column is edited which makes this hardly usable in lower versions. MySQL seems to report this since 5.7.
  • Virtual columns are supported by other databases (MS SQL, Oracle, maybe others). Can the support be added for them too?

Has this been tested with routines? The functionality in editing.inc.php is used there too and the virtual columns are not supported there.

@vrana vrana closed this Jan 22, 2019
@vrana vrana mentioned this pull request Jan 22, 2019
kixe pushed a commit to kixe/adminer that referenced this pull request Jan 28, 2019
mevdschee added a commit to mevdschee/adminer that referenced this pull request Oct 6, 2020
Fix vrana#325 (broken search on timestamp/boolean fields) for adminer editor
vrana added a commit that referenced this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants