-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.3 error suppression #484
base: master
Are you sure you want to change the base?
Conversation
PHP 8.3 has shortened the array access on null error message to "Trying to access array offset on null". This commit changes the regular expression used to circumvent errors.
+1 |
Thank you very much for this correction. |
please release a new version compatible with php 8.3 |
Just for personal curiosity, why the choice is to catch these errors in this way, instead of adapting the code to avoid generating theses errors? |
Thanks for patch, merged to https://github.com/pematon/adminer |
The repo doesn't seem to be maintained since 3 years |
I know and I don't want to use AdminerEvo. That's why I'm patching my own fork... (feel free to check it out 😉). |
it's sad that some forks have to be solved and not just one... It would be better to solve it in one place (here - official place), it's a sad that Mr. Vrána (@vrana) doesn't have time to approve "new" PRs :( |
PHP 8.3 has shortened the array access on null error message to "Trying to access array offset on null". This commit changes the regular expression used to circumvent errors.