Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 error suppression #484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PHP 8.3 error suppression #484

wants to merge 1 commit into from

Conversation

Sneda8
Copy link

@Sneda8 Sneda8 commented Dec 17, 2023

PHP 8.3 has shortened the array access on null error message to "Trying to access array offset on null". This commit changes the regular expression used to circumvent errors.

PHP 8.3 has shortened the array access on null error message to "Trying to access array offset on null". This commit changes the regular expression used to circumvent errors.
@jeffwhansen
Copy link

+1

@diam
Copy link

diam commented Jan 5, 2024

Thank you very much for this correction.
When will you be able to publish an updated version, please?

@nbao
Copy link

nbao commented Jun 19, 2024

please release a new version compatible with php 8.3

@SkyEmie
Copy link

SkyEmie commented Jul 21, 2024

Just for personal curiosity, why the choice is to catch these errors in this way, instead of adapting the code to avoid generating theses errors?

@peterpp
Copy link
Contributor

peterpp commented Sep 5, 2024

Thanks for patch, merged to https://github.com/pematon/adminer

@SkyEmie
Copy link

SkyEmie commented Sep 12, 2024

The repo doesn't seem to be maintained since 3 years
I suggest using the fork https://github.com/adminerevo/adminerevo instead

@peterpp
Copy link
Contributor

peterpp commented Sep 12, 2024

The repo doesn't seem to be maintained since 3 years I suggest using the fork https://github.com/adminerevo/adminerevo instead

I know and I don't want to use AdminerEvo. That's why I'm patching my own fork... (feel free to check it out 😉).

@ShaiMagal
Copy link

ShaiMagal commented Oct 25, 2024

it's sad that some forks have to be solved and not just one... It would be better to solve it in one place (here - official place), it's a sad that Mr. Vrána (@vrana) doesn't have time to approve "new" PRs :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants