Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the AllChildrenPathSubjectPart case in the TraversalValidator commented out? #87

Open
vrenken opened this issue Jul 6, 2021 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@vrenken
Copy link
Owner

vrenken commented Jul 6, 2021

Orignal code is:

case ParentPathSubjectPart:
    ValidateParentPathSubjectPart(beforePathPart, afterPathPart);
    break;
// TODO: This probably should be activated, removed, and maybe also make us reflect on the other parent/child traversers.
// case AllChildrenPathSubjectPart:
//     if (beforePathPart is ChildrenPathSubjectPart or afterPathPart is ChildrenPathSubjectPart or beforePathPart is AllChildrenPathSubjectPart or afterPathPart is AllChildrenPathSubjectPart)
//     {
//         throw new ScriptParserException("The all children path separator cannot be combined.")
//     }
//     if (afterPathPart is ParentPathSubjectPart)
//     {
//         throw new ScriptParserException("The all children path separator cannot be followed by a parent path separator.")
//     }
//     if (afterPathPart is AllParentsPathSubjectPart)
//     {
//         throw new ScriptParserException("The all children path separator cannot be followed by an all parents path separator.")
//     }
//     break
case ChildrenPathSubjectPart:
    ValidateChildrenPathSubjectPart(beforePathPart, afterPathPart);
    break;
@vrenken vrenken added enhancement New feature or request question Further information is requested labels Jul 6, 2021
vrenken pushed a commit that referenced this issue Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

1 participant