Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REKDAT-179 sysadmin only organization member views #290

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

bzar
Copy link
Contributor

@bzar bzar commented Oct 1, 2024

  • Added authorization overrides for member_list, organization_members, organization_member_create and organization_member_delete
  • Added test to make sure an organization admin cannot view organization member list, create or delete views

@bzar bzar changed the title Rekdat 179 sysadmin only organization member views REKDAT-179 sysadmin only organization member views Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.07%. Comparing base (cf84f17) to head (f1f0925).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   79.71%   80.07%   +0.36%     
==========================================
  Files          19       19              
  Lines        1760     1797      +37     
  Branches        1        1              
==========================================
+ Hits         1403     1439      +36     
- Misses        357      358       +1     
Flag Coverage Δ
cdk 100.00% <ø> (ø)
ckan 79.89% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Zharktas Zharktas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing coverage could be tested by simple test with dataset in group and calling member_list for that e.g. https://dev.suojattudata.suomi.fi/api/action/member_list?id=koulutus-kulttuuri-ja-urheilu&object_type=package

@bzar bzar merged commit 0077682 into main Oct 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants