Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate MToon format.g.cs in VRMShaders #927

Merged
merged 2 commits into from
May 6, 2021

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented May 6, 2021

  • Generator can generate different directories between format and serializer.
  • Generate MToon format.g.cs in Assets/VRMShaders/VRM10/Format/Runtime/MaterialsMToon

@Santarh Santarh requested a review from ousttrue May 6, 2021 10:03
File.WriteAllText(path, contents, Encoding.UTF8);
}

public static void GenerateTo(JsonSchemaSource root, DirectoryInfo formatDir, DirectoryInfo serializerDir)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatDir と serializerDir が分かれた

// VRMC_materials_mtoon
"vrm-specification/specification/VRMC_materials_mtoon-1.0_draft/schema/VRMC_materials_mtoon.schema.json",
"Assets/VRM10/Runtime/Format/MaterialsMToon", // dst
"Assets/VRMShaders/VRM10/Format/Runtime/MaterialsMToon", // format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ

Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう

@ousttrue ousttrue merged commit 93b87c9 into vrm-c:master May 6, 2021
@ousttrue ousttrue added the 1.0 label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants