-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] change: new constraint spec #355
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b5vr
added
documentation
Improvements or additions to documentation
schema
Constraint
labels
Feb 25, 2022
fix required field of constraint
doctoc README.ja.md
fix typo
fix wrong required spec on explainer
add English explainer
英語仕様まで書き終わりました。 |
UpperArm-LowerArmはAimとRollを組み合わせないと難しそうなので、これの言及は仕様内ではやめておく
fromToQuatをローカル空間に戻すのを忘れていた
ousttrue
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
よさそう
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Mar 4, 2022
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Mar 4, 2022
3 tasks
0b5vr
changed the title
[1.0] WIP change: new constraint spec
[1.0] change: new constraint spec
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
前回の技術委員会での議論に基づき、コンストレイントの仕様に対して大幅な改訂を行いました。
今回の仕様ですが、Domain Specificに、使用用途に直結するコンストレイントの仕様を定義することを目指しました。
これまでのコンストレイントの議論での、環境間の挙動の差異の吸収・厳密な挙動の定義を行うことの難しさを踏まえ、
「このコンストレイントはこう使う」という使用用途に最適化したコンストレイントへの仕様の変更を行いました。
そのため、実装間での挙動の差異についてはある程度寛容な仕様となっています。
加えて、設定項目も最低限に留めることにより、実装・使用共により簡単となることを目指しています。
TODOs
Points need review