[1.0] SpringBone.center 復活 #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Center. Update exporter and importer.
Santarh
approved these changes
May 30, 2022
| @@ -38,9 +38,6 @@ public enum UpdateTypes | |||
| [SerializeField, Header("Runtime")] | |||
| public UpdateTypes UpdateType = UpdateTypes.LateUpdate; | |||
|
|
|||
| [SerializeField] | |||
| public Transform SpringBoneCenter; | |||
| @@ -33,6 +33,9 @@ public class Spring | |||
| [SerializeField] | |||
| public List<VRM10SpringBoneJoint> Joints = new List<VRM10SpringBoneJoint>(); | |||
|
|
|||
| [SerializeField] | |||
| public Transform Center; | |||
| @@ -72,7 +72,7 @@ private FastSpringBoneBuffer CreateFastSpringBoneBuffer(Vrm10InstanceSpringBone | |||
| return new FastSpringBoneBuffer( | |||
| springBone.Springs.Select(spring => new FastSpringBoneSpring | |||
| { | |||
| center = m_target.SpringBoneCenter, | |||
| center = spring.Center, | |||
There was a problem hiding this comment.
FastSpringBone の実装は Spring ごとに Center が違うことを想定しているかな？
してそうだけど、要確認
| var center = model.Nodes.IndexOf(converter.Nodes[x.Center.gameObject]); | ||
| if (center != -1) | ||
| { | ||
| spring.Center = center; |
There was a problem hiding this comment.
Center が設定されていれば、ノード番号を得て Export する
| @@ -595,6 +595,11 @@ async Task LoadSpringBoneAsync(IAwaitCaller awaitCaller, Vrm10Instance controlle | |||
| var spring = new Vrm10InstanceSpringBone.Spring(gltfSpring.Name); | |||
| controller.SpringBone.Springs.Add(spring); | |||
|
|
|||
| if (gltfSpring.Center.HasValue) | |||
| { | |||
| spring.Center = Nodes[gltfSpring.Center.Value]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vrm-c/vrm-specification#374