Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include using full relative path #187

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

mickeprag
Copy link
Contributor

This is needed by Arduino since it is not yet supported to specify
include directories manually

Fixes #185

This is needed by Arduino since it is not yet supported to specify
include directories manually
@martinberlin martinberlin self-requested a review June 4, 2022 19:21
@martinberlin martinberlin added the arduino-ide building this with arduino ESP32 label Jun 4, 2022
@martinberlin
Copy link
Collaborator

martinberlin commented Jun 4, 2022

@Yardie- can you please test Micke's branch and add it as an Arduino library?

I think the issue with Arduino IDE is that it expects all header includes without relative paths.

Please note that in my comment on Slack I mentioned without relative paths (Not with relative paths). Please read this as a reference.
I just tried to build the dragon example in IDF after this update and it still works. Now when I try to add a symlink to this branch in Arduino libraries:

martin@martin-IdeaPad:~/snap/arduino/current/Arduino/libraries/epdiy$ ln -s /home/martin/esp/projects/pull-requests/epdiy-micke epdiy

I see it coming and have an example also in Arduino, that I have latest version in Ubuntu installed using Snap (check patch), when I try to build it I get:

   from /home/martin/snap/arduino/current/Arduino/libraries/epdiy/src/epd_driver/i2s_data_bus_s2.c:1:
/home/martin/snap/arduino/61/.arduino15/packages/esp32/hardware/esp32/2.0.2/tools/sdk/esp32/include/soc/esp32/include/soc/rtc.h:16:21: error: #include nested too deeply
 #include <stdbool.h>
                     ^
/home/martin/snap/arduino/61/.arduino15/packages/esp32/hardware/esp32/2.0.2/tools/sdk/esp32/include/soc/esp32/include/soc/rtc.h:17:20: error: #include nested too deeply
 #include <stddef.h>
                    ^

Like if Arduino is struggling with the include levels...Arghh...well I really don't use this IDE, other than for quick tries on other boards than ESP32. So I'm quite lost to test this. Can you please give it a try?

Micke I think we should also base this update in Valentin's idea to do this that you can see in the actual repository (Ex. epd_board.h)

Copy link
Collaborator

@martinberlin martinberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this after Gregory testing in Slack

@martinberlin martinberlin merged commit 4ad5615 into vroland:master Jun 5, 2022
@mickeprag mickeprag deleted the 185-arduino branch August 26, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino-ide building this with arduino ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile errors with Arduino
2 participants