Vendor Waveforms and Library Refactoring #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroland
force-pushed
the
waveforms
branch
2 times, most recently
from
441d5bf
to
096d623
Compare
|
@vroland This is very nice! Maybe you can add links in the documentation? |
|
@mcer12 Yes, I'll do that. I don't think we're big enough for anyone to care and remove the linked files, so maintaining a link repository should be possible. |
also increase line skip time, 2 2 is too short.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this is done, it will extend the EPDIY component, such that it can use the vendor-provided waveform files.
This will be slower because of the limited memory bandwidth of the ESP32, but will produce better-quality images (#52).
Unfortunately, it's currently unclear wether the waveform files are copyrightable, so I will not distribute them in this repository for now. Some can be found through searching the web or dumping flash chips. Long therm, it would be great to generate our own waveforms.
Ideas about this issue are always welcome!