This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Add rotera item api #172
Merged
Add rotera item api #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! Everything seems good, but you need to add tests and run lints using |
|
Oh, and just ignore the typing check failing—it is pydantic issue |
Signed-off-by: Maik Riechert <letmaik@outlook.com>
letmaik
commented
May 2, 2023
|
Coverage still fails, please cover 28–29 lines |
Fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://www.ikea.com/global/assets/rotera/resources/30221043.json
This allows to fetch 3D models from the returned URLs.