fix: update browser tab title on notebook rename, prioritize app title.

Fixes marimo-team#1428
vrtnis · May 28, 2024 · a8d10bb · a8d10bb
1 parent d1debeb
commit a8d10bb
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 18 deletions.
diff --git a/examples/dashboards/movies.py → examples/dashboards/movies350.py b/examples/dashboards/movies.py → examples/dashboards/movies350.py
@@ -1,7 +1,7 @@
 import marimo
 
-__generated_with = "0.1.33"
-app = marimo.App(width="full")
+__generated_with = "0.6.10"
+app = marimo.App(width="full", app_title="Movies_Neat")
 
 
 @app.cell
@@ -57,14 +57,12 @@ def handle_click(v):
     return button_00s, button_10s, button_80s, button_90s, decade_button
 
 
-@app.cell
-def __(mo, previous_end_date, previous_start_date):
-    mo.md(
-        f"""
-    > Compared to: {previous_start_date.strftime("%Y-%m-%d")} - {previous_end_date.strftime("%Y-%m-%d")}
-    """
-    )
-    return
+app._unparsable_cell(
+    r"""
+    mo.md(f\"> Compared to: {previous_start_date.strftime(\\"%Y-%m-%d\\")} - {previous_end_date.strftime(\\"%Y-%m-%d\\")}\")
+    """,
+    name="__"
+)
 
 
 @app.cell

diff --git a/frontend/src/core/edit-app.tsx b/frontend/src/core/edit-app.tsx
@@ -1,13 +1,11 @@
 /* Copyright 2024 Marimo. All rights reserved. */
 import { useCallback, useEffect, useState } from "react";
-
 import {
   sendComponentValues,
   sendInterrupt,
   sendRename,
   sendSave,
 } from "@/core/network/requests";
-
 import { Controls } from "@/components/editor/controls/Controls";
 import { FilenameInput } from "@/components/editor/header/filename-input";
 import { FilenameForm } from "@/components/editor/header/filename-form";
@@ -118,7 +116,8 @@ export const EditApp: React.FC<AppProps> = ({ userConfig, appConfig }) => {
     return sendRename(name)
       .then(() => {
         setFilename(name);
-        document.title = name || "Untitled Notebook"; // Assign a default title if name is null
+         // Set document title: app_title takes precedence, then filename, then default
+        document.title = appConfig.app_title || name || "Untitled Notebook"; 
         return name;
       })
       .catch((error) => {
@@ -127,10 +126,11 @@ export const EditApp: React.FC<AppProps> = ({ userConfig, appConfig }) => {
       });
   });
 
-  // Update document title whenever filename changes
+  // Update document title whenever filename or app_title changes
   useEffect(() => {
-    document.title = filename || "Untitled Notebook"; // Assign a default title if filename is null
-  }, [filename]);
+    // Set document title: app_title takes precedence, then filename, then default
+    document.title = appConfig.app_title || filename || "Untitled Notebook"; 
+  }, [appConfig.app_title, filename]);
 
   const cells = notebookCells(notebook);
   const cellIds = cells.map((cell) => cell.id);

diff --git a/marimo/_tutorials/plots.py → marimo/_tutorials/plots1.py b/marimo/_tutorials/plots.py → marimo/_tutorials/plots1.py
@@ -1,8 +1,9 @@
 # Copyright 2024 Marimo. All rights reserved.
+
 import marimo
 
-__generated_with = "0.1.69"
-app = marimo.App()
+__generated_with = "0.6.10"
+app = marimo.App(app_title="plots99")
 
 
 @app.cell(hide_code=True)