Removed goji in favor of the gorrila/mux package #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoism
force-pushed
the
mux-server
branch
4 times, most recently
from
4ec7c15
to
f64b1a3
Compare
twoism
pushed a commit
that referenced
this pull request
Mar 21, 2016
Removed goji in favor of the gorrila/mux package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gojidependency was a little heavy handed for handlinga single endpoint. This branch switches to the gorilla/mux
package for routing and refactors everything else to work as
vanilla net/http
Handlers andHandlerFuncs.This also gave me the chance to make
goji-testwork fornet/httpandgoji. I'll post a follow up PR for that.