Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watch (KVsToFeatureMap) to respect the namespace #69

Merged
merged 2 commits into from
May 10, 2018
Merged

Fix watch (KVsToFeatureMap) to respect the namespace #69

merged 2 commits into from
May 10, 2018

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Mar 13, 2018

No description provided.

@fruch
Copy link
Contributor Author

fruch commented Mar 13, 2018

depeds on #70 to pass in CI

@fruch
Copy link
Contributor Author

fruch commented May 6, 2018

@promiseofcake can you review this change ?

@brendanjryan
Copy link
Contributor

Sorry for the delay on this! The code change looks good to me - would it be possible to add a test for the change in functionality?

@fruch
Copy link
Contributor Author

fruch commented May 9, 2018

I could give it a try, but seem like none of the tests does those:

  1. configure anything other then default
  2. Save Info (sha and timestamp) into the mock storage, and not flags

again my go is a bit rust ;)

@fruch
Copy link
Contributor Author

fruch commented May 9, 2018

@brendanjryan done, and even passing in CI

brendanjryan
brendanjryan approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@brendanjryan brendanjryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome --- thank you! LGTM!

promiseofcake
promiseofcake approved these changes May 10, 2018
View reviewed changes
Copy link
Contributor

@promiseofcake promiseofcake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, I have been out on paternity leave.

@promiseofcake promiseofcake merged commit e3a1ff2 into vsco:master May 10, 2018
@fruch
Copy link
Contributor Author

fruch commented May 10, 2018

@promiseofcake 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@promiseofcake promiseofcake promiseofcake approved these changes

@brendanjryan brendanjryan brendanjryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruch @brendanjryan @promiseofcake