Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for precommit #1946

Merged
merged 2 commits into from
Apr 7, 2019

Conversation

KingDarBoja
Copy link
Member

Fixes #1700

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Had to remake the icon based on the png, good thing it wasn't too complex :D

@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #1946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1946   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          77      77           
  Lines        5819    5819           
  Branches      131     131           
======================================
  Hits         5819    5819
Impacted Files Coverage Δ
src/iconsManifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad020ac...bbdba7d. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #1946 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1946   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          77      77           
  Lines        5819    5819           
  Branches      131     131           
======================================
  Hits         5819    5819
Impacted Files Coverage Δ
src/iconsManifest/supportedExtensions.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714f362...aec9663. Read the comment docs.

@Alhadis
Copy link

Alhadis commented Apr 6, 2019

Had to remake the icon based on the png, good thing it wasn't too complex :D

@KingDarBoja You were more than welcome to work off file-icons's SVG, if it would have helped. =)

@KingDarBoja
Copy link
Member Author

Had to remake the icon based on the png, good thing it wasn't too complex :D

@KingDarBoja You were more than welcome to work off file-icons's SVG, if it would have helped. =)

Had no idea about those icons, but glad if I can use them if need :)

@robertohuertasm robertohuertasm added this to the Next milestone Apr 7, 2019
@robertohuertasm robertohuertasm merged commit d65407f into vscode-icons:master Apr 7, 2019
@KingDarBoja KingDarBoja deleted the precommit-icon branch April 20, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants