-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke haxe in cwd #6
Conversation
But why? We already specify |
(and that is also how what the language server does for display requests) |
When lix is installed, the Anyway I think this is more correct as it mimic the behaviour of running the haxe command in cli manually. |
In that case this patch should also be applied there. And perhaps that would solve some lix-related problems. |
Well, what confused me is that it seems to work ok for the language server, but not eval-debugger? @nadako Is there a particular reason we don't just set the cwd / would tha even work for us? |
I guess it "works" because it invoked haxe in lix's global scope instead of the project-specified one? Perhaps that's why there are problems sometimes, which might be due to incompatible haxe version with some libraries. |
It seems to me that it simply because cwd doesn't matter for the haxe compiler (it is the case if the haxe compiler never access the process's cwd). The |
I don't remember ^^ But in general, if we ever want to share haxe server across e.g. workspace folders, we'd still need to do |
FWIW, Lix users want to use the project's specified haxe version for each workspace. So unless the haxe version are exactly the same they shouldn't be shared. |
Anyway, if this helps, I'll just merge it for now. I don't have a Lix setup, so I trust that it works. :) |
Fixes lix-pm/lix.client#72