-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haxe server should not use --wait stdio #217
Comments
It still seems nice to have a proxy in case we need to restart the server ( |
Although I can agree on the second point (the first one is just a compiler bug), I won't change this unless there's a "non-hack" solution to address issues mentioned in HaxeFoundation/haxe#5188. |
I also experience problems in a big project which i think are related to this, will try to figure that out when i have more time. |
So I was taking a bath and suddenly it occured to me that we can do the same trick as in the
|
So finding a free port is the only blocker to not using |
this should address all issues: free ports (just bind to 0) and knowing when connection can be/is established (Haxe will connect to us itself and then we're ready to communicate) |
I started working on that, though I don't have a lot of free time nowadays. |
* [server] implement --wait-connect (see vshaxe/vshaxe#217) * [CLI] remove rogue parens * [CLI] change to --server-listen and --server-connect
Communications on stdout/stdin are error prone for several reasons:
I recommend moving to proper socket and drop the hack that makes haxe language server opens a proxy socket
The text was updated successfully, but these errors were encountered: