Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding minio user alerting #178

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Adding minio user alerting #178

merged 3 commits into from
Jun 11, 2024

Conversation

wejdross
Copy link
Member

Summary

  • Adding VSHNMinio user alerting

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues.

@wejdross wejdross added the enhancement New feature or request label Jun 10, 2024
@wejdross wejdross self-assigned this Jun 10, 2024
@wejdross wejdross marked this pull request as ready for review June 10, 2024 08:58
@wejdross wejdross requested review from a team, Kidswiss, TheBigLee and zugao and removed request for a team June 10, 2024 08:58
@wejdross wejdross mentioned this pull request Jun 10, 2024
Merged
4 tasks
zugao
zugao approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess the common package will do the job. Please test the alerting before deploying to prod.

@wejdross
Copy link
Member Author

LGTM. I guess the common package will do the job. Please test the alerting before deploying to prod.

just for the sake of this MR - deployed change to LAB and triggered and alert, email was sent successfully, merging

@wejdross wejdross merged commit ae7aa99 into master Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@Kidswiss Kidswiss Kidswiss approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

Assignees

@wejdross wejdross

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wejdross @Kidswiss @zugao