Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Improve kind builds for different CPU architectures #24

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Improve kind builds for different CPU architectures #24

merged 2 commits into from
Apr 19, 2022

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Apr 19, 2022

Summary

  • Instead of go run .../kind, we'll prebuild the binary on first use and put it into the .kind dir
  • Invoke docker rmi in the make clean target

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

Improves kind startup time by prebuilding the binary for the specific OS the user has.
Also fixes the app container image to linux/amd64 since this is the arch kind runs the cluster, even on mac/arm.
@ccremer ccremer added the change label Apr 19, 2022
@ccremer ccremer requested a review from Kidswiss April 19, 2022 10:23
@ccremer ccremer merged commit 3f97a48 into master Apr 19, 2022
@ccremer ccremer deleted the arch branch April 19, 2022 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants