Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable output of golang-ci in the job logs #48

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Enable output of golang-ci in the job logs #48

merged 1 commit into from
Oct 26, 2022

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Oct 25, 2022

Summary

  • Run golangci-lint from makefile
  • Enable printing of file and line number (GitHub annotations still work)
  • Downloads golangci-lint if not available in .work/bin

Example run with a failed linting error: https://github.com/vshn/provider-exoscale/actions/runs/3322352402/jobs/5491250517

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@ccremer ccremer added the change label Oct 25, 2022
@ccremer ccremer force-pushed the ci-output branch 3 times, most recently from 9ff06a0 to 0d4a925 Compare October 25, 2022 15:26
@ccremer
Copy link
Contributor Author

ccremer commented Oct 25, 2022

Example run with a failed linting error: https://github.com/vshn/provider-exoscale/actions/runs/3322352402/jobs/5491250517

@ccremer ccremer force-pushed the ci-output branch 2 times, most recently from 177cefd to 891c56a Compare October 25, 2022 15:45
@ccremer ccremer marked this pull request as ready for review October 25, 2022 15:50
@ccremer ccremer merged commit 30cd7ff into master Oct 26, 2022
@ccremer ccremer deleted the ci-output branch October 26, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant