Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/client bugs #55

Merged
merged 6 commits into from
Mar 28, 2019
Merged

Fix/client bugs #55

merged 6 commits into from
Mar 28, 2019

Conversation

vsoch
Copy link
Owner

@vsoch vsoch commented Mar 27, 2019

This will fix two client bugs:

  1. arguments aren't correctly passed with run.

I've pushed the container vanessa/scif:hw to test this fix, here is an example of arguments being passed correctly:

$ docker run -it vanessa/scif:hw run hello-world-custom THINGONE
[hello-world-custom] executing /bin/bash /scif/apps/hello-world-custom/scif/runscript THINGONE
Hello THINGONE

$ docker run -it vanessa/scif:hw run hello-world-custom THINGONE THINGTWO
[hello-world-custom] executing /bin/bash /scif/apps/hello-world-custom/scif/runscript THINGONE THINGTWO
Hello THINGONE THINGTWO

$ docker run -it vanessa/scif:hw run hello-world-custom THINGONE THINGTWO --omg
[hello-world-custom] executing /bin/bash /scif/apps/hello-world-custom/scif/runscript THINGONE THINGTWO --omg
Hello THINGONE THINGTWO --omg
  1. The next issue is that exec was hitting the runscript (instead of executing the command). Here is the fixed example:
$ docker run vanessa/scif:hw exec hello-world-env echo "Meatballs"
[hello-world-env] executing /bin/echo Meatballs
Meatballs

In addition, I've updated the date in the headers.

This will close #54 #53

Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
@vsoch
Copy link
Owner Author

vsoch commented Mar 27, 2019

Note: just changed so that if there is no runscript, it alerts the user and exits.

Copy link

@bilke bilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed the implementation but run and exec now work as expected, thanks a lot!!

@vsoch
Copy link
Owner Author

vsoch commented Mar 28, 2019

okay cool! I tested most bits so I'm good to merge. Please open another issue if you run into any more, and always glad to help :) I'll release this on pypi in a minute and post the link here.

@vsoch vsoch merged commit 3675b28 into master Mar 28, 2019
@vsoch vsoch deleted the fix/client-bugs branch March 28, 2019 14:49
@vsoch
Copy link
Owner Author

vsoch commented Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runscript shouldn't be written if no apprun section
2 participants