exit with the exit code from a app when run() #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmachi this is a black formatting issue unrelated to your work. Would you like me to push a fixed PR with formatting, or do you want to run it here alongside your work? Either works for me, I can still review with the extra noise. And note the CI is installing |
|
@vsoch, thanks. If you can push a fixed PR with formatting that'd be great. I'd do it myself, but its not clear to me what I need to do. |
|
okay all set - you should be able to rebase on master now. |
|
Thanks, I've merged these changes back into my fork. Do you need me to do anything else on this PR? |
vsoch
approved these changes
Jan 24, 2024
|
Thank you @dmachi ! https://pypi.org/project/scif/0.0.82/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the run() command exit with the same exit code as the app being run. It is a straight forward update. I have created an apptainer test following the pattern used for "exit-on-install", though mine builds a apptainer/singularity image instead of a docker image as I don't have an easy place to run as docker at the moment. This patch includes updating the CHANGELOG and the version of the package, however it was not clear to me from the contributing guidelines whether I should update the version or not. If you'd like me to back any of that out, please let me know. I also didnt' see a "development" branch for the merge, so this PR is against master.