fix: Incorrect pointer arithmetics in ucl_expand_single_variable #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one I'm not 100% sure, but other code paths in that function are doing it this way. As I said in previous issue, I had UclObjects holding bytes related to previous allocations. I *think* it's related to this code block. Valgrind showed read/write problems related to those pointers as well. Hopefully this is last PR for this function.
|
The strange thing is that I have tested this variables expansion many times in Rspamd in conjunction with asan/valgrind. But it has not revealed any issues. Perhaps, in my scenarios, I never wanted ucl to free the variables (meaning transfering memory ownership to libucl from variables handlers). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one I'm not 100% sure, but other code paths in that function are doing it this way.
As I said in previous issue, I had UclObjects holding bytes related to previous allocations. I think it's related to this code block. Valgrind showed read/write problems related to those pointers as well.
Hopefully this is last PR for this function.