Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css handles #192

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Css handles #192

merged 4 commits into from
Oct 23, 2019

Conversation

iaronaraujo
Copy link
Contributor

What is the purpose of this pull request?

Add CssHandles

How should this be manually tested?

Workspace

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 21, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 21, 2019

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@iaronaraujo
Copy link
Contributor Author

Needs vtex-apps/css-handles#10

[tabbedShelf.itemContainerUnselected]: !isSelected,
const itemContainer = classNames(`t-body pa4 tl bb b--muted-4 ${cssHandles.itemContainer}`, {
[`bg-base--inverted c-on-muted-1 ${cssHandles.itemContainerSelected}`]: isSelected,
[cssHandles.itemContainerUnselected]: !isSelected,
'bw0': isLast,
})
return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might add a new CSS handle to the button right below this line (I could not select it because it was not changed)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware that it might not be that useful, but just to prevent anyone from asking it in the future hahahha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- A few new css class handles and changed them to use the `cssHandles` app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A few new css class handles and changed them to use the `cssHandles` app
- A few new CSS handles and changed them to use the `cssHandles` app

@iaronaraujo iaronaraujo merged commit ed88b41 into master Oct 23, 2019
@iaronaraujo iaronaraujo deleted the chore/css-handles branch October 23, 2019 19:31
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 23, 2019

Your PR has been merged! App is being published. 🚀
Version 1.31.4 → 1.31.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants