-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Css handles #192
Css handles #192
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
Needs vtex-apps/css-handles#10 |
[tabbedShelf.itemContainerUnselected]: !isSelected, | ||
const itemContainer = classNames(`t-body pa4 tl bb b--muted-4 ${cssHandles.itemContainer}`, { | ||
[`bg-base--inverted c-on-muted-1 ${cssHandles.itemContainerSelected}`]: isSelected, | ||
[cssHandles.itemContainerUnselected]: !isSelected, | ||
'bw0': isLast, | ||
}) | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might add a new CSS handle to the button right below this line (I could not select it because it was not changed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware that it might not be that useful, but just to prevent anyone from asking it in the future hahahha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) | |||
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). | |||
|
|||
## [Unreleased] | |||
### Added | |||
- A few new css class handles and changed them to use the `cssHandles` app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A few new css class handles and changed them to use the `cssHandles` app | |
- A few new CSS handles and changed them to use the `cssHandles` app |
Your PR has been merged! App is being published. 🚀 |
What is the purpose of this pull request?
Add CssHandles
How should this be manually tested?
Workspace