Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-10859 - updating Product Images #1109

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

barbara-celi
Copy link
Contributor

@barbara-celi barbara-celi commented Jun 14, 2024

What problem is this solving?

Including blockClass in the props list.

EDU-10859

How to test it?

[Workspace](Link goes here!)

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@barbara-celi barbara-celi self-assigned this Jun 14, 2024
@barbara-celi barbara-celi requested a review from a team as a code owner June 14, 2024 16:37
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 14, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@barbara-celi barbara-celi removed the request for review from JulianaMeyerArruda June 14, 2024 16:37
@barbara-celi barbara-celi requested a review from a team as a code owner June 14, 2024 16:39
@barbara-celi barbara-celi requested review from gvc, GusGuerra, vsseixaso and carolinamenezes and removed request for gvc, GusGuerra and vsseixaso June 14, 2024 16:39
Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barbara-celi barbara-celi merged commit 8a7a8f6 into master Aug 1, 2024
1 of 4 checks passed
@barbara-celi barbara-celi deleted the fix/EDU-10859-update-productImages branch August 1, 2024 15:47
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 1, 2024

Your PR has been merged! App is being published. 🚀
Version 3.174.0 → 3.174.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store-components@3.174.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants