Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sticky ios #104

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Fix/sticky ios #104

merged 3 commits into from
Sep 6, 2019

Conversation

lbebber
Copy link
Contributor

@lbebber lbebber commented Sep 6, 2019

What is the purpose of this pull request?

Fixes iOS issue where sticky would not work.

https://lbebber--storecomponents.myvtex.com/

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@lbebber lbebber requested a review from a team September 6, 2019 14:38
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 6, 2019

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 6, 2019

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@jgfidelis jgfidelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its better to use the tachyons sticky :)

@lbebber lbebber merged commit 8c0eb48 into master Sep 6, 2019
@lbebber lbebber deleted the fix/sticky-ios branch September 6, 2019 16:20
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 6, 2019

Your PR has been merged! App is being published. 🚀
Version 2.21.6 → 2.21.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants