fix number not appearing using geolocation in NZL #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
jeffersontuc
approved these changes
May 15, 2023
camilavcoutinho
force-pushed
the
newzealand/fix_4.x
branch
from
1165f0b
to
c9a7789
Compare
lucasecdb
suggested changes
May 15, 2023
Co-authored-by: Lucas Cordeiro <ecdb.lucas@gmail.com>
lucasecdb
approved these changes
May 15, 2023
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixing the street/house number not appearing on the address form after an address is selected. Customers are negatively impacted by the missing street number, assuming the order will not be delivered.
It relates to closed PR #516 and #519
What problem is this solving?
to replicate the scenario, access vineonline.myvtex.com, add any item to your cart and proceed to checkout. When asked for your address, start typing 48 Avalon Drive ... full address includes Forest Lake, 3200, Hamilton City, but we use Google Maps API for auto-complete. When you select the address, you will notice that the street number (48 in this case) goes missing. Hopefully with this deploy, that number will appear during the checkout process on the address form.
How should this be manually tested?
https://localization--vineonline.myvtex.com/checkout/#/shipping
Screenshots or example usage
Types of changes