-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat!: Adds EmptyState content-type and enable EmptyState
section override
#2184
Merged
eduardoformiga
merged 15 commits into
3.x
from
feat/section-override-empty-state-fs-1239
Jan 30, 2024
Merged
Feat!: Adds EmptyState content-type and enable EmptyState
section override
#2184
eduardoformiga
merged 15 commits into
3.x
from
feat/section-override-empty-state-fs-1239
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
eduardoformiga
requested review from
emersonlaurentino and
renatamottam
and removed request for
a team
December 28, 2023 22:40
hellofanny
changed the title
Feat: section override
Feat!: Adds EmptyState content-type and enable Jan 10, 2024
EmptyState
EmptyState
section override
hellofanny
added
breaking changes
This pull request will introduce breaking changes
don't merge
Blocked by some reason - - Please mention the reason
labels
Jan 24, 2024
Merged
eduardoformiga
added a commit
that referenced
this pull request
Jan 31, 2024
## What's the purpose of this pull request? This PR holds the PRs that will be available in 3.x version: - #2184 - #2198 - #2176 Preview PR - vtex-sites/starter.store#360 --------- Co-authored-by: Fanny <fanny.chien@vtex.com.br> Co-authored-by: Ícaro Azevedo <icaro.azevedo@vtex.com> Co-authored-by: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking changes
This pull request will introduce breaking changes
don't merge
Blocked by some reason - - Please mention the reason
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach introduces Breaking Changes
What's the purpose of this pull request?
EmptyState
is a complex section that is being used directly (without CMS) on the error 500, error 404, and login pages.While we've been doing section override 2.0, we've seen that it wouldn't be possible without bringing this section to the CMS and making it more generic (without direct use on the pages).
So, the idea we discussed is to create three new content-types (login, 500, and 404) and use the EmptyState section on these pages.
EmptyState
EmptyState
EmptyState
EmptyState
to use Section Override API v2.How to test it?
formspacefs1239
in thefaststore.config.default.js
file.yarn dev
.If they are not created, you should run in the workspace formspacefs1239 the commands:
Also, add the
EmptyState
section to every page.References